From 12c74eba6af8655116e5c372d7a6cd2dcaaf8572 Mon Sep 17 00:00:00 2001 From: Emil Ohlsson Date: Thu, 15 May 2025 15:38:41 +0200 Subject: [PATCH 1/2] Address linter issues Newer versions of the linter flags issues with parentheis in expressionss, as well as use of `size_t` without inclusion of `stddef.h` Signed-off-by: Emil Ohlsson --- .clang-tidy | 3 ++- ...mul_clamp_f32_qsi8d32p1x8_qsi4c32p4x8_1x4x32_neon_dotprod.c | 1 + kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f16_neon.c | 1 + kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f32.c | 1 + kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32.c | 3 ++- .../matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32_neon.c | 3 ++- .../matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f16_neon.c | 1 + .../matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f32_neon.c | 1 + 8 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index b2f304c5..ae6ba597 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,5 +1,5 @@ # -# SPDX-FileCopyrightText: Copyright 2024 Arm Limited and/or its affiliates +# SPDX-FileCopyrightText: Copyright 2024-2025 Arm Limited and/or its affiliates # # SPDX-License-Identifier: Apache-2.0 # @@ -24,3 +24,4 @@ Checks: > -readability-function-cognitive-complexity, -readability-identifier-length, -readability-magic-numbers, + -readability-math-missing-parentheses, diff --git a/kai/ukernels/matmul/matmul_clamp_f32_qsi8d32p_qsi4c32p/kai_matmul_clamp_f32_qsi8d32p1x8_qsi4c32p4x8_1x4x32_neon_dotprod.c b/kai/ukernels/matmul/matmul_clamp_f32_qsi8d32p_qsi4c32p/kai_matmul_clamp_f32_qsi8d32p1x8_qsi4c32p4x8_1x4x32_neon_dotprod.c index 69096ff7..6aa84def 100644 --- a/kai/ukernels/matmul/matmul_clamp_f32_qsi8d32p_qsi4c32p/kai_matmul_clamp_f32_qsi8d32p1x8_qsi4c32p4x8_1x4x32_neon_dotprod.c +++ b/kai/ukernels/matmul/matmul_clamp_f32_qsi8d32p_qsi4c32p/kai_matmul_clamp_f32_qsi8d32p1x8_qsi4c32p4x8_1x4x32_neon_dotprod.c @@ -10,6 +10,7 @@ #include "kai_matmul_clamp_f32_qsi8d32p1x8_qsi4c32p4x8_1x4x32_neon_dotprod.h" #include +#include #include #include "kai/kai_common.h" diff --git a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f16_neon.c b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f16_neon.c index 14f4768e..e941a926 100644 --- a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f16_neon.c +++ b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f16_neon.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include "kai/kai_common.h" diff --git a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f32.c b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f32.c index 4f7c756c..eed1da28 100644 --- a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f32.c +++ b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qai8dxp_f32.c @@ -10,6 +10,7 @@ #endif #include #include +#include #include #include "kai/kai_common.h" diff --git a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32.c b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32.c index a75daf27..de57678d 100644 --- a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32.c +++ b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32.c @@ -1,11 +1,12 @@ // -// SPDX-FileCopyrightText: Copyright 2024 Arm Limited and/or its affiliates +// SPDX-FileCopyrightText: Copyright 2024-2025 Arm Limited and/or its affiliates // // SPDX-License-Identifier: Apache-2.0 // #include "kai_lhs_quant_pack_qsi8d32p_f32.h" #include +#include #include #include "kai/kai_common.h" diff --git a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32_neon.c b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32_neon.c index 70298754..736c8086 100644 --- a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32_neon.c +++ b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32p_f32_neon.c @@ -1,5 +1,5 @@ // -// SPDX-FileCopyrightText: Copyright 2024 Arm Limited and/or its affiliates +// SPDX-FileCopyrightText: Copyright 2024-2025 Arm Limited and/or its affiliates // // SPDX-License-Identifier: Apache-2.0 // @@ -11,6 +11,7 @@ #include "kai_lhs_quant_pack_qsi8d32p_f32_neon.h" #include +#include #include #include "kai/kai_common.h" diff --git a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f16_neon.c b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f16_neon.c index 288d778b..5096f29e 100644 --- a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f16_neon.c +++ b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f16_neon.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include "kai/kai_common.h" diff --git a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f32_neon.c b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f32_neon.c index 0854148e..13571b59 100644 --- a/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f32_neon.c +++ b/kai/ukernels/matmul/pack/kai_lhs_quant_pack_qsi8d32pscalef32_f32_neon.c @@ -12,6 +12,7 @@ #include #include +#include #include #include "kai/kai_common.h" -- GitLab From 2a75ff770bc6b69657a72dd74c96cb6525c41641 Mon Sep 17 00:00:00 2001 From: Emil Ohlsson Date: Thu, 15 May 2025 16:07:00 +0200 Subject: [PATCH 2/2] Also remove _trailing return type_ Signed-off-by: Emil Ohlsson --- .clang-tidy | 1 + 1 file changed, 1 insertion(+) diff --git a/.clang-tidy b/.clang-tidy index ae6ba597..615da704 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -21,6 +21,7 @@ Checks: > -bugprone-easily-swappable-parameters, -cppcoreguidelines-avoid-magic-numbers, -llvm-header-guard, + -modernize-use-trailing-return-type, -readability-function-cognitive-complexity, -readability-identifier-length, -readability-magic-numbers, -- GitLab