From 6bc032bd30d4aeb25c9bff181b3118fdac33d004 Mon Sep 17 00:00:00 2001 From: Felix Thomasmathibalan Date: Tue, 18 Feb 2025 08:33:55 +0000 Subject: [PATCH] Remove unused lhs_stride argument lhs stride is removed from kai_run_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot Signed-off-by: Felix Thomasmathibalan --- ...i_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.c | 5 ++--- ...i_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.h | 5 ++--- .../kai_matmul_clamp_qai8_qai8_qsi8cxp_interface.h | 4 ++-- test/tests/matmul_clamp_qai8_qai8p_qsi8cxp_test.cpp | 2 +- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.c b/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.c index 288c207f..e638e69e 100644 --- a/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.c +++ b/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.c @@ -75,11 +75,10 @@ size_t kai_get_dst_size_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot(si } void kai_run_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot( - size_t m, size_t n, size_t k, const void* lhs, size_t lhs_stride, const void* rhs_packed, void* dst, - size_t dst_stride_row, size_t dst_stride_col, const struct kai_matmul_requantize32_params* params) { + size_t m, size_t n, size_t k, const void* lhs, const void* rhs_packed, void* dst, size_t dst_stride_row, + size_t dst_stride_col, const struct kai_matmul_requantize32_params* params) { KAI_UNUSED(dst_stride_row); KAI_UNUSED(dst_stride_col); - KAI_UNUSED(lhs_stride); KAI_ASSUME(m == 1); typedef struct { diff --git a/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.h b/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.h index cb2932f9..21f4076a 100644 --- a/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.h +++ b/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot.h @@ -101,15 +101,14 @@ size_t kai_get_dst_size_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot(si /// @param[in] n Number of output columns to be computed. /// @param[in] k Common dimension of the LHS and RHS operand. /// @param[in] lhs LHS matrix buffer. -/// @param[in] lhs_stride Row stride in bytes of the LHS matrix. Unused parameter. /// @param[in] rhs_packed Packed RHS matrix buffer. /// @param[out] dst Output matrix buffer. /// @param[in] dst_stride_row Row stride in bytes of the output matrix. Currently, an unused parameter. /// @param[in] dst_stride_col Column stride in bytes of the output matrix. Currently, an unused parameter. /// @param[in] params Quantization parameters void kai_run_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot( - size_t m, size_t n, size_t k, const void* lhs, size_t lhs_stride, const void* rhs_packed, void* dst, - size_t dst_stride_row, size_t dst_stride_col, const struct kai_matmul_requantize32_params* params); + size_t m, size_t n, size_t k, const void* lhs, const void* rhs_packed, void* dst, size_t dst_stride_row, + size_t dst_stride_col, const struct kai_matmul_requantize32_params* params); #ifdef __cplusplus } // extern "C" diff --git a/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp_interface.h b/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp_interface.h index 9b59dd6c..618bd7ae 100644 --- a/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp_interface.h +++ b/kai/ukernels/matmul/matmul_clamp_qai8_qai8_qsi8cxp/kai_matmul_clamp_qai8_qai8_qsi8cxp_interface.h @@ -28,8 +28,8 @@ typedef size_t (*kai_matmul_clamp_qai8_qai8_qsi8cxp_get_dst_size_func_t)(size_t /// Micro-kernel core function ("run" method) typedef void (*kai_matmul_clamp_qai8_qai8_qsi8cxp_run_matmul_func_t)( - size_t m, size_t n, size_t k, const void* lhs, size_t lhs_stride, const void* rhs_packed, void* dst, - size_t dst_stride_row, size_t dst_stride_col, const struct kai_matmul_requantize32_params* params); + size_t m, size_t n, size_t k, const void* lhs, const void* rhs_packed, void* dst, size_t dst_stride_row, + size_t dst_stride_col, const struct kai_matmul_requantize32_params* params); /// Micro-kernel interface struct kai_matmul_clamp_qai8_qai8p_qsi8cxp_ukernel { diff --git a/test/tests/matmul_clamp_qai8_qai8p_qsi8cxp_test.cpp b/test/tests/matmul_clamp_qai8_qai8p_qsi8cxp_test.cpp index 252dd2fb..eec9d022 100644 --- a/test/tests/matmul_clamp_qai8_qai8p_qsi8cxp_test.cpp +++ b/test/tests/matmul_clamp_qai8_qai8p_qsi8cxp_test.cpp @@ -179,7 +179,7 @@ const std::array gemv_variants = { [](size_t m, size_t n, size_t k, const void* lhs, const void* rhs, void* dst, size_t dst_stride_row, size_t dst_stride_col, const kai_matmul_requantize32_params* quant_param) { kai_run_matmul_clamp_qai8_qai8_qsi8cxp2vlx4sb_1x16vl_sme2_dot( - m, n, k, lhs, sizeof(int8_t), rhs, dst, dst_stride_row, dst_stride_col, quant_param); + m, n, k, lhs, rhs, dst, dst_stride_row, dst_stride_col, quant_param); }, }, }, -- GitLab