From 202636f6c6137770da694403c007f709bc8ecf68 Mon Sep 17 00:00:00 2001 From: Viet-Hoa Do Date: Mon, 3 Jun 2024 13:36:38 +0100 Subject: [PATCH 1/2] Fix multi-isa build feature * Explicitly build NEON-only files with the base architecture. * Remove redundant compiler flags. Signed-off-by: Viet-Hoa Do --- CMakeLists.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 822c1137..5a9639b6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -93,12 +93,12 @@ target_compile_options(kleidiai PRIVATE ${KLEIDIAI_WARNING_FLAGS} ) -foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON_DOTPROD) - set_property(SOURCE ${KLEIDIAI_SOURCE_FILE} PROPERTY COMPILE_OPTIONS -march=armv8.2-a+dotprod) +foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON) + set_property(SOURCE ${KLEIDIAI_SOURCE_FILE} PROPERTY COMPILE_OPTIONS -march=armv8-a) endforeach() -foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON_I8MM) - set_property(SOURCE ${KLEIDIAI_SOURCE_FILE} PROPERTY COMPILE_OPTIONS -march=armv8.2-a+i8mm) +foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON_DOTPROD) + set_property(SOURCE ${KLEIDIAI_SOURCE_FILE} PROPERTY COMPILE_OPTIONS -march=armv8.2-a+dotprod) endforeach() foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON_FP16) -- GitLab From bd6d7173e5f4fd48bffb6ebadce8e58b5b0bd2ff Mon Sep 17 00:00:00 2001 From: Viet-Hoa Do Date: Wed, 5 Jun 2024 15:35:12 +0100 Subject: [PATCH 2/2] Remove redundant build flags Signed-off-by: Viet-Hoa Do --- CMakeLists.txt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5a9639b6..9cf9cea8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -97,10 +97,6 @@ foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON) set_property(SOURCE ${KLEIDIAI_SOURCE_FILE} PROPERTY COMPILE_OPTIONS -march=armv8-a) endforeach() -foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON_DOTPROD) - set_property(SOURCE ${KLEIDIAI_SOURCE_FILE} PROPERTY COMPILE_OPTIONS -march=armv8.2-a+dotprod) -endforeach() - foreach(KLEIDIAI_SOURCE_FILE IN LISTS KLEIDIAI_FILES_NEON_FP16) set_property(SOURCE ${KLEIDIAI_SOURCE_FILE} PROPERTY COMPILE_OPTIONS -march=armv8.2-a+fp16) endforeach() -- GitLab