From cfbccab3a69cab510436985796c6f1ab2af38af2 Mon Sep 17 00:00:00 2001
From: Brett Warren <brett.warren@arm.com>
Date: Fri, 21 Jun 2019 13:10:33 +0100
Subject: [PATCH] scmi : Replace usage of strcpy

This patch replaces strcpy for copying literal

Change-Id: I7695cee46958facb79829241b8b4b6f3848adeb1
Signed-off-by: Brett Warren <brett.warren@arm.com>
---
 module/scmi/src/mod_scmi.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/module/scmi/src/mod_scmi.c b/module/scmi/src/mod_scmi.c
index ea61e03ab..ed3a2766e 100644
--- a/module/scmi/src/mod_scmi.c
+++ b/module/scmi/src/mod_scmi.c
@@ -9,6 +9,7 @@
  */
 
 #include <stdbool.h>
+#include <stdio.h>
 #include <string.h>
 #include <fwk_assert.h>
 #include <fwk_errno.h>
@@ -504,8 +505,13 @@ static int scmi_base_discover_agent_handler(fwk_id_t service_id,
     return_values.status = SCMI_SUCCESS;
 
     if (parameters->agent_id == SCMI_PLATFORM_ID) {
-        strcpy(return_values.name, "platform");
-        goto exit;
+       static const char name[] = "platform";
+
+       static_assert(sizeof(return_values.name) >= sizeof(name),
+              "return_values.name is not large enough to contain name");
+
+       memcpy(return_values.name, name, sizeof(name));
+       goto exit;
     }
 
     agent = &scmi_ctx.config->agent_table[parameters->agent_id];
-- 
GitLab