Change-Id: Id4f3902985ee54530318551bdad12f4fe6481981
Signed-off-by: Ronald Cron <ronald.cron@arm.com>

Update firmware version to v2.4 and update the readme
file accordingly.

Change-Id: Id619c1e0efa513a96c6c5ab6038ee1b76c0ad70d
Signed-off-by: Ronald Cron <ronald.cron@arm.com>

The User guide describes how to use the SCP and MCP
firmware, including required tooling and environment
set-up, and also guidance on building and deploying
the firmware.

Change-Id: I248e0b97469669fa87366624e422a6d5c2f8df8a
Signed-off-by: Ronald Cron <ronald.cron@arm.com>

Change-Id: I85c2d0fb089c70b83609b3fbfa5a965ebf855680
Signed-off-by: Ronald Cron <ronald.cron@arm.com>

This patch adds flags enabling the linker to remove functions and data
that are not referenced, substantially reducing the size of the final
binary.

Change-Id: I4b276eb27fed776de78f2dd22c9658609643cb6b
Signed-off-by: Chris Kay <chris.kay@arm.com>

The use case for the dual region memory layout without .data relocation
is for firmware with dual RAMs - one on the instruction bus and one on
the data bus. The linker scripts currently incorrectly place read-only
data in the instruction-optimized RAM when it belongs in the data-
optimized RAM.

Change-Id: I742ab6907327cd8399b6faf3d3a34507ae1002de
Signed-off-by: Chris Kay <chris.kay@arm.com>

This commit moves common linker script configuration options to an
independent header file that is now included from both the Arm Compiler
and LD linker scripts.

Change-Id: I0ad252cfbbb28cc482a9612da0dac87bb8e9f471
Signed-off-by: Chris Kay <chris.kay@arm.com>

Change-Id: I97f6736d56d3e1f42a219547833abb1a5f54d03c
Signed-off-by: Chris Kay <chris.kay@arm.com>

Minimizing the amount of assembly we use makes it easier to understand
the early boot flow and how objects are placed in the ELF image.

Additionally, arm_init_ccr() is no longer called before the C runtime
initialization is done, and is instead called by main().

Change-Id: Ib539bd45fb707d6948cc925a024cce803051ff8a
Signed-off-by: Chris Kay <chris.kay@arm.com>

This is in order to avoid conflicts with other names in the global
namespace.

Change-Id: I18f2ec432ef4cc02254e94a4cd02b3c1e789a6fe
Signed-off-by: Chris Kay <chris.kay@arm.com>

This flag stops Arm Compiler 6 from complaining about the linker-defined
symbols.

Change-Id: Ide8b3c0315129d04fe1aa1d126cb7131dfd1d553
Signed-off-by: Chris Kay <chris.kay@arm.com>

This change is being made to claw back some of the bloat caused by
certain optimizations that are enabled by -O3.

Change-Id: Ide36c162104be784dabbfec16974090591293dde
Signed-off-by: Chris Kay <chris.kay@arm.com>

Change-Id: I46ec2ca3a8b9f6f05dd4bbbf5f164160d2f9fcf5

Change-Id: Ib5a9f055b147433a55bbd09be69ae86e6dbf62f9
Signed-off-by: Chris Kay <chris.kay@arm.com>

With the stackheap model this option is meaningless as the stack and the
heap grow towards each other until they collide.

Change-Id: I75577536356236e3fe5a9ce0d22bb06de9acf43f
Signed-off-by: Chris Kay <chris.kay@arm.com>

The stack/heap separation has been removed, allowing us to treat the
stack and the heap as a single block of memory. This allows us to grow
them towards each other rather than giving them both a fixed, non-
overlapping size.

Change-Id: I537535eeb21c947dc657daaacb75ebf2d9eeb7c5
Signed-off-by: Chris Kay <chris.kay@arm.com>

Change-Id: I8b054eba5c58edf18dfb372addea5bb36946a501
Signed-off-by: Chris Kay <chris.kay@arm.com>

Region aliases allow us to specify alternative names for memory regions.
This is particularly useful for sections that are not located in mem0,
as it allows us to conditionally alias the mem1 region based on the
firmware configuration.

Change-Id: I490c513758caa8580fd1d633dcf8f774290b45cc
Signed-off-by: Chris Kay <chris.kay@arm.com>

- Remove the custom crt0 initialization routines
- Implement required Newlib symbols
    This includes _exit() and main() as well as __bss_start__,
    __bss_end__ and __stack, which are all used by newlib's crt0
    routines.

Change-Id: I229509c56bcccbfdbdf5700a5f048767aa9ecea5
Signed-off-by: Chris Kay <chris.kay@arm.com>

All of these issues stem from assuming that passing a pointer-to-mutable
will initialize the object if it's not already initialized, but it's
unsafe to assume this is the case even if it is judged that the call
returned successfully, as the implementation may change at any point.

Change-Id: Ica114514429005b18d04efce2529e0a64a182525
Signed-off-by: Chris Kay <chris.kay@arm.com>

The headers these constructs belong in were introduced with C11
standard library, but don't appear to be supported by the Arm Compiler
6's. We work around this by implementing them ourselves.

Change-Id: I601701c0a8e2b5df02e7c2c95c5b0667aac6cff4
Signed-off-by: Chris Kay <chris.kay@arm.com>

We need to transition to this style in order to support armclang's
assembly parser.

Change-Id: Id08f21196ed411e1022484fb0876770d210136d8
Signed-off-by: Chris Kay <chris.kay@arm.com>

If alarm_stop() is called while the interrupt are globally disabled,
it is possible that an interrupt is pending because the alarm being stopped
has triggered. To avoid the execution of the timer ISR after the alarm has
been stopped, this interrupt is cleared in the function.

Change-Id: I3bbce3aeb447546e541b3d6d453a16f5b4db9445
Signed-off-by: Elieva Pignat <Elieva.Pignat@arm.com>

In 'alarm_stop()', if the ISR belonging to 'alarm_id' is executed
between the check on 'alarm->started' and the call to
'ctx->driver_disable', then the alarm is removed from the active
alarms list twice (once in the ISR 'timer_isr()' and again at the
end of 'alarm_stop()').

To avoid this scenario, these two operations have been reordered
to ensure the interrupt has been disabled before any checks are
made.

Change-Id: I5d11ddc5ed35fa87f7ff7361a518d504e285b248
Signed-off-by: Elieva Pignat <Elieva.Pignat@arm.com>

If a dlist contained more than two nodes, the previous link
of the new list head was not updated and pointed still to the
popped head.

Change-Id: I19507a6910d714f441290db8de5481113847370d
Signed-off-by: Elieva Pignat <Elieva.Pignat@arm.com>

PIK clock divider value limit checking is hardcoded to 16 with
4-bit assumption. However many mobile & infra platforms has
5-bit divider.

This patch fixes the issue by adding a configurable module parameter
so that the platform's config file can set the divider bitfield size
based on platform.

Additionally, if platform does not provide module configuration data,
then the divider limit is set to a default value of 5-bits.

Change-Id: I70103ec84eacc2d26be999ca6524878bff51dd9d
Signed-off-by: Manoj Kumar <manoj.kumar3@arm.com>

When an alarm is triggered a callback function is called instead
of sending an event to the module or element that set the alarm.

That way an alarm trigger does not necessarily generate an event
and for example register polling can be done more effectively.

Change-Id: I7ef16976c8f90e3f772ae57056f5891636533170
Signed-off-by: Elieva Pignat <Elieva.Pignat@arm.com>

Fix typo in the word "contributions".

Change-Id: I3051031a981bf0104b2b5a849a8e28090bcbd592
Signed-off-by: Filipe Rinaldi <filipe.rinaldi@arm.com>

This patch enables a number of useful warning flags, namely -pedantic
and -pedantic-errors. It also re-enables the strict aliasing warning.

Change-Id: Id912e0dae914e6a9eebbeef727bd4447ebe18c21
Signed-off-by: Chris Kay <chris.kay@arm.com>

Fix `dereferencing type-punned pointer will break strict-aliasing rules`
errors.

Change-Id: I3eef4c8df85104e1b96edc7da7d5f68cf1455bfc
Signed-off-by: Chris Kay <chris.kay@arm.com>

Fix `pointers to arrays with different qualifiers are incompatible in
ISO C` errors.

Change-Id: I97eca84df6e9bc23250457191b5695adc92fe24c
Signed-off-by: Chris Kay <chris.kay@arm.com>

Fix `ISO C99 requires at least one argument for the "..." in a variadic
macro` errors.

Change-Id: Ied477b9eac9f552a7896379618f5b6668d0ef651
Signed-off-by: Chris Kay <chris.kay@arm.com>

Fix `ISO C forbids 'return' with expression, in function returning void`
errors.

Change-Id: Idf7c0284f15c0e2228c9eace02cbb132a3ccb38e
Signed-off-by: Chris Kay <chris.kay@arm.com>

Change-Id: I4b7dd6d19b795d46f0420a4e7138d9e2685fd772
Signed-off-by: Chris Kay <chris.kay@arm.com>

Change-Id: Ieebd946caf9be40018e87109f7b35ac904203e42
Signed-off-by: Chris Kay <chris.kay@arm.com>

This occurs when enabling -pedantic as statement expressions are a GNU
extension.

Change-Id: I6afe1065373518c489ca5f9bba13e5f554704a86
Signed-off-by: Chris Kay <chris.kay@arm.com>

Change-Id: I978ce4e6d7b81a9cbe9313a2e6b855f767294ffd
Signed-off-by: Chris Kay <chris.kay@arm.com>

This commit moves all inclusions of <assert.h> into <fwk_assert.h>,
which now includes it instead. This allows us to keep all assert-related
logic under one roof.

Change-Id: I4ec0d950dfd9264733645bc14da952b8c1619501
Signed-off-by: Chris Kay <chris.kay@arm.com>

Renamed as all symbols/define exposed by the build system should
have the prefix BUILD_ in their names.

Change-Id: I8893121b32c31584a163a991547925cc028ee1c9
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

This commit moves PEP8 to PyCodeStyle and ensures the build environment
for each compilation is using the correct toolchain.

Change-Id: I7c26c94c6b1d2cc072eda80307246a2ae21c1c0f
Signed-off-by: Chris Kay <chris.kay@arm.com>