Update the version in Cmake and readme files to
new release version v2.16.

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

Add new section for v2.16.0 change log.

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

Francesco Rosati authored Feb 27, 2025 and Mohamed Omar Asaker committed Mar 04, 2025

A new unit test case has been added to check that we return an error
if pointers meant to be used to return data as parameters are NULL.

Signed-off-by: Francesco Rosati <francesco.rosati@arm.com>

Francesco Rosati authored Feb 26, 2025 and Mohamed Omar Asaker committed Mar 04, 2025

A bitwise OR operator has been used instead of the logical one
inside an if statement in ccsm_mod_set_configuration().

Also an assert meant to check for pointers passed as parameters
to be non NULL failed to properly do that, allowing for a
potential NULL pointer dereference later on in
get_register_value_rate().

Signed-off-by: Francesco Rosati <francesco.rosati@arm.com>

Arm provides a PGP method for reporting security vulnerabilities. This patch
documents the public key and updates the email alias for reporting issues.
Additionally, the security section in the README file is redundant,
so it is being removed.

Signed-off-by: Tarek El-Sherbiny <tarek.el-sherbiny@arm.com>

Mina Aziz authored Feb 20, 2025 and Mina Aziz committed Feb 25, 2025

Removing James McGregor from maintainers list.
Adding the following to the sub-maintainers list
- Mina Aziz
- Matthew Wellings
- Wei-Chia
- Mahmoud Elsabbagh
- Francesco Rosati

Signed-off-by: mina.aziz <mina.aziz@arm.com>

Replace a wrong build flag in CMakeLists.txt that was checked to
enable scmi power capping standard commands.

Signed-off-by: Ahmed Gadallah <ahmed.gadallah@arm.com>

Mahmoud Elsabbagh authored Jan 30, 2025 and Ahmed Gadallah committed Feb 25, 2025

Add a .md file to power capping HAL explaining how it uses
PID controller module and how it integrates with the rest
of the system.

Signed-off-by: Mahmoud Elsabbagh <mahmoud.elsabbagh@arm.com>

Mahmoud Elsabbagh authored Jan 27, 2025 and Ahmed Gadallah committed Feb 25, 2025

The renaming was carried out as perf controller use cases
grow larger, its components names need to be renamed to adapt
to the new use cases. The blocks core and cluster would be
renamed limiter and controller domain to avoid confusion and to
be more generic.

The controller domain in the system consists of various performance
limiters and applies the lowest performance limit across the domain.

Signed-off-by: Mahmoud Elsabbagh <mahmoud.elsabbagh@arm.com>

Update the unit testing for pinctrl and scmi_pinctrl regarding the integration test resuls.

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

This patch addresses several issues in the `scmi_pinctrl` and `pictrl` module.
The following bugs have been fixed:
- Update message_attribute command.
- Solve scmi_pin_control bug in list_association.
- Solve scmi_pin_control bug in get_setting.
- Remove unimplemented protocols from scmi_pin_control.
- Update scmi_pin_control payload size table.
- Update the scmi_validation check to ignore variable length payload messages.
- Update the MOD_PIN_CONTROL_API to MOD_PINCTRL_API_IDX.

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

Add pinctrl_drv as a mock driver.

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

Francesco Rosati authored Feb 20, 2025 and Leandro Belli committed Feb 21, 2025

Some unit tests in mod_dvfs_unit_test.c initialise local data
structures with the minimum information required to test DVFS
functions.

The local data structures sometimes have pointers in them that
depending on the particular test being run - should also be
initialised, but in some cases the unit test failed to do that.

This resulted in some pointers being initialised with whatever
random data was on the stack and depending on what ended in those
pointers, accessing data fields through them could end in a segfault.

The fix makes sure all pointers that need initialising are
properly set.

Signed-off-by: Francesco Rosati <francesco.rosati@arm.com>

Fixing the issue with cluster performance limit not being updated
and stuck at configuration value, which led to performance requests
that were done after cluster_apply_performance_granted to be limited
incorrectly.

Signed-off-by: Ahmed Gadallah <ahmed.gadallah@arm.com>

Update the build_system.md to remove references to the legacy Makefile system.
Replace them with modern CMake workflows and ensure consistency with the latest build practices.
Integrate content from cmake_readme.md into a unified guide.

Signed-off-by: Mahmoud Elsabbagh <mahmoud.elsabbagh@arm.com>

Add the construction of the tree traverse order table.
The table shall be used during calculations and distribution of
limits, demands, and budgets.

Traverseing order will be level by level (breadth first walk).

The construction is based on detecting the root and adding it to
the traverse order table then looping through the table adding
children to the end.

Unit test added.

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>

Add a str define for module name to be used in logging.

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>

Add a definition to be used as index for domains have no parents.
i.e. root domain.

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>

Fix domain configuration struct typo
mod_power_distibutor_domain_config to
mod_power_distributor_domain_config

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>

This patch removes a now moot dependency with the Power Domain
from the System Power Requester UTs.

Signed-off-by: Katherine Vincent <katherine.vincent@arm.com>

Leandro Belli authored Feb 12, 2025 and Mohamed Omar Asaker committed Feb 18, 2025

The previous implementation relied on `find -printf`, which is not portable
across different operating systems. This caused build inconsistencies when
attempting to compile the project in various environments.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>

Enable the Instruction access Cacheability control bit in SCTLR_EL2 at
the same time as enabling the MPU. This improves the performance of
instruction fetches on hardware where this is implemented.

Signed-off-by: Peter Hoyes <peter.hoyes@arm.com>

Vincent Guittot authored Jan 24, 2025 and Leandro Belli committed Feb 11, 2025

When notification is not enabled, power_domain_notifications.c must not be
compiled.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

python3 from 3.7.9 to 3.10.16
ARM compiler 6 from 6.13 to 6.20

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

Remove power_coordinator and power_meter files and all their dependecies
in scmi_power_capping and replace the apis with the ones provided
in power_capping_hal.

Signed-off-by: Mahmoud Elsabbagh <mahmoud.elsabbagh@arm.com>

Update SCMI Power Capping to use apis provided by Power Capping HAL
for reporting power averaging interval and average consumed power.

Signed-off-by: Mahmoud Elsabbagh <mahmoud.elsabbagh@arm.com>

Apply PID feedback on Power Cap requested by the agent as follows:
1) The set point is the requested cap by the agent.
2) The feedback is the average measured power.
3) The output is a power limit that is delivered to the power distributor.

The usage of the PID would allow the Power Cap not to be set directly
to the system although a margin would be there to allow bursts of performance
applied on the system for a short period of time.

The PID is called continuously on intervals inside the get_power_limit function
called from metrics_analyzer.

Signed-off-by: Mahmoud Elsabbagh <mahmoud.elsabbagh@arm.com>

Unit testing the pinctrl APIs implementation.

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

Make changes in set/get configuration regarding the change in the requirement analysis
to prevent set/get configuration if the group has more than one pin and is not GPIO.

Make a small change in the get_function_attributes to match the change in the group functionality
which allows every group to be linked to one and only one function.

Signed-off-by: Khaled Ali Ahmed <khaled.aliahmed@arm.com>

Change SCP CI script to allow user to specify the docker tag if they would like to run with different docker image.

Signed-off-by: Mahmoud Elsabbagh <mahmoud.elsabbagh@arm.com>

Wei-Chia Su authored Nov 12, 2024 and Wei-Chia Su committed Jan 14, 2025

In the SCMI handler table, unsupported messages are indicated by leaving the
corresponding function pointer unassigned. However, there is no validation
check on entry which leads to potential null pointer dereference while handling
message. This change explicitly initializes the handler table and validates
entry in runtime to determine whether a given message is supported.

Signed-off-by: Wei-Chia Su <Wei-Chia.Su@arm.com>

Wei-Chia Su authored Nov 12, 2024 and Wei-Chia Su committed Jan 14, 2025

In the SCMI handler table, unsupported messages are indicated by leaving the
corresponding function pointer unassigned. However, there is no validation
check on entry which leads to potential null pointer dereference while handling
message. This change explicitly initializes the handler table and validates
entry in runtime to determine whether a given message is supported.

Signed-off-by: Wei-Chia Su <Wei-Chia.Su@arm.com>

Wei-Chia Su authored Nov 12, 2024 and Wei-Chia Su committed Jan 14, 2025

In the SCMI handler table, unsupported messages are indicated by leaving the
corresponding function pointer unassigned. However, there is no validation
check on entry which leads to potential null pointer dereference while handling
message. This change explicitly initializes the handler table and validates
entry in runtime to determine whether a given message is supported.

This change addresses the security vulnerability (CVE-2024-11864).

Signed-off-by: Wei-Chia Su <Wei-Chia.Su@arm.com>

Wei-Chia Su authored Nov 19, 2024 and Wei-Chia Su committed Jan 14, 2025

This patch updates unit tests to cover the change of validation in message
handler.

Signed-off-by: Wei-Chia Su <Wei-Chia.Su@arm.com>

Wei-Chia Su authored Nov 12, 2024 and Wei-Chia Su committed Jan 14, 2025

In the SCMI handler table, unsupported messages are indicated by leaving the
corresponding function pointer unassigned. However, there is no validation
check on entry which leads to potential null pointer dereference while handling
message. This change explicitly initializes the handler table and validates
entry in runtime to determine whether a given message is supported.

This change addresses the security vulnerability (CVE-2024-11863).

Signed-off-by: Wei-Chia Su <Wei-Chia.Su@arm.com>

Change pipeline name to the MR number for pipeline trigger for public
repo MR. This helps in identifying public MR pipeline more easily.

Signed-off-by: Wen Ping Teh <wenping.teh@arm.com>

Following the commit fc76620a
Coverity template job is completely removed from codebase.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>

Pranav Madhu authored Dec 21, 2023 and Thomas Abraham committed Jan 10, 2025

Add support in SCP to report a shutdown or cold reboot to RSE. SCP uses
MHU outband communication, and uses SCMI messaging format to communicate
with RSE.

The current implementation of RSE do not support SCMI. This patch can be
removed once SCMI support is enabled in RSE. In that scenario, RSE will
subscribe to the system power-down notifications, which will then be
handled directly by the SCP SCMI module.

Change-Id: I8c7f75c7d5714e381ee8b60e1e86ccd2f93a19e9
Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>

Pranav Madhu authored Feb 13, 2024 and Thomas Abraham committed Jan 10, 2025

When SCP platform module binds to SCMI module, SCMI module will try to
bind back to platform  module. Add support for the bind back APIs.

The current implementation of RSE do not support SCMI. This patch can be
removed once SCMI support is enabled in RSE. In that scenario, RSE will
subscribe to the system power-down notifications, which will then be
handled directly by the SCP SCMI module.

Change-Id: Ib41a414f29797c9e9d7c5bade56f5f4cb6403c24
Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>

Pranav Madhu authored Feb 13, 2024 and Thomas Abraham committed Jan 10, 2025

SCP platform module to bind with SCP-RSE SCMI channel. SCP uses this
channel to report shutdown and cold reboot requests to RSE.

The current implementation of RSE do not support SCMI. This patch can be
removed once SCMI support is enabled in RSE. In that scenario, RSE will
subscribe to the system power-down notifications, which will then be
handled directly by the SCP SCMI module.

Change-Id: Ib912ddb668c88ed036d0876c0824ae743ff06bdd
Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>