From 20a84407e64720ede648a62cd0da6b7c9fa5cd42 Mon Sep 17 00:00:00 2001
From: Alex Tercete <alex.tercete@arm.com>
Date: Fri, 17 Jan 2025 14:11:03 +0000
Subject: [PATCH] feat(transition): remove rule

It's the same as `bazel-lib`'s `platform_transition_binary`[1], so
there's no need to maintain our own version.

[1]: https://github.com/bazel-contrib/bazel-lib/blob/main/docs/transitions.md#platform_transition_binary
---
 labgrid/transition/BUILD.bazel             | 15 -----------
 labgrid/transition/defs.bzl                |  5 ----
 labgrid/transition/platform/BUILD.bazel    |  7 -----
 labgrid/transition/platform/transition.bzl | 15 -----------
 labgrid/transition/rule.bzl                | 31 ----------------------
 5 files changed, 73 deletions(-)
 delete mode 100644 labgrid/transition/BUILD.bazel
 delete mode 100644 labgrid/transition/defs.bzl
 delete mode 100644 labgrid/transition/platform/BUILD.bazel
 delete mode 100644 labgrid/transition/platform/transition.bzl
 delete mode 100644 labgrid/transition/rule.bzl

diff --git a/labgrid/transition/BUILD.bazel b/labgrid/transition/BUILD.bazel
deleted file mode 100644
index 398fc033..00000000
--- a/labgrid/transition/BUILD.bazel
+++ /dev/null
@@ -1,15 +0,0 @@
-load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
-
-bzl_library(
-    name = "defs",
-    srcs = ["defs.bzl"],
-    visibility = ["//visibility:public"],
-    deps = [":rule"],
-)
-
-bzl_library(
-    name = "rule",
-    srcs = ["rule.bzl"],
-    visibility = ["//visibility:public"],
-    deps = ["//labgrid/transition/platform:transition"],
-)
diff --git a/labgrid/transition/defs.bzl b/labgrid/transition/defs.bzl
deleted file mode 100644
index 0990b226..00000000
--- a/labgrid/transition/defs.bzl
+++ /dev/null
@@ -1,5 +0,0 @@
-load(":rule.bzl", _transition = "transition")
-
-visibility("public")
-
-labgrid_transition = _transition
diff --git a/labgrid/transition/platform/BUILD.bazel b/labgrid/transition/platform/BUILD.bazel
deleted file mode 100644
index 189d2d59..00000000
--- a/labgrid/transition/platform/BUILD.bazel
+++ /dev/null
@@ -1,7 +0,0 @@
-load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
-
-bzl_library(
-    name = "transition",
-    srcs = ["transition.bzl"],
-    visibility = ["//visibility:public"],
-)
diff --git a/labgrid/transition/platform/transition.bzl b/labgrid/transition/platform/transition.bzl
deleted file mode 100644
index 57d60d22..00000000
--- a/labgrid/transition/platform/transition.bzl
+++ /dev/null
@@ -1,15 +0,0 @@
-visibility("//...")
-
-def implementation(_, attr):
-    return [
-        {"//command_line_option:platforms": str(platform)}
-        for platform in attr.platforms
-    ]
-
-labgrid_transition_platform = transition(
-    implementation = implementation,
-    inputs = [],
-    outputs = ["//command_line_option:platforms"],
-)
-
-platform = labgrid_transition_platform
diff --git a/labgrid/transition/rule.bzl b/labgrid/transition/rule.bzl
deleted file mode 100644
index 9e098b6f..00000000
--- a/labgrid/transition/rule.bzl
+++ /dev/null
@@ -1,31 +0,0 @@
-load("//labgrid/transition/platform:transition.bzl", _transition = "platform")
-
-visibility("//...")
-
-DOC = ""
-
-ATTRS = {
-    "platforms": attr.label_list(
-        doc = "Platforms to transition `srcs` to.",
-        providers = [platform_common.PlatformInfo],
-    ),
-    "srcs": attr.label_list(
-        doc = "Outputs to transition to `platforms`.",
-        cfg = _transition,
-        allow_files = True,
-    ),
-}
-
-def implementation(ctx):
-    files = depset(transitive = [s.files for s in ctx.attr.srcs])
-    runfiles = ctx.runfiles()
-    runfiles = runfiles.merge_all([s.default_runfiles for s in ctx.attr.srcs])
-    return DefaultInfo(files = files, runfiles = runfiles)
-
-labgrid_transition = rule(
-    doc = DOC,
-    attrs = ATTRS,
-    implementation = implementation,
-)
-
-transition = labgrid_transition
-- 
GitLab