From 6c0bc741e94c6b196a1439d34948f499148a1ccb Mon Sep 17 00:00:00 2001 From: Anjali Kumar Date: Wed, 19 Mar 2025 14:14:53 +0000 Subject: [PATCH] test(false): add native and pytest tests for false --- e2e/binary/false/BUILD.bazel | 31 +++++++++++++++++++++++++------ e2e/binary/false/false.py | 13 +++++++++++++ 2 files changed, 38 insertions(+), 6 deletions(-) create mode 100644 e2e/binary/false/false.py diff --git a/e2e/binary/false/BUILD.bazel b/e2e/binary/false/BUILD.bazel index 8301ea9d..93637039 100644 --- a/e2e/binary/false/BUILD.bazel +++ b/e2e/binary/false/BUILD.bazel @@ -1,11 +1,30 @@ -load("@bazel_skylib//rules:build_test.bzl", "build_test") +load("@bazel_skylib//rules:native_binary.bzl", "native_test") +load("@rules_python_pytest//python_pytest:defs.bzl", "py_pytest_test") -# TODO: write an _actual_ test for `false` +py_pytest_test( + name = "pytest", + size = "small", + srcs = ["false.py"], + data = [ + "@ape//ape:false", + ], + deps = [ + "//binary:pytest", + ], +) -build_test( - name = "false", +native_test( + name = "native", size = "small", - tags = ["stub"], - targets = ["@ape//ape:false"], + src = "@ape//ape:false", + args = ["hello"], +) + +test_suite( + name = "false" + tests = [ + "native", + "pytest", + ], visibility = ["//:__subpackages__"], ) diff --git a/e2e/binary/false/false.py b/e2e/binary/false/false.py new file mode 100644 index 00000000..45ff0b51 --- /dev/null +++ b/e2e/binary/false/false.py @@ -0,0 +1,13 @@ +from __future__ import annotations + +from subprocess import run, CalledProcessError +import pytest + +from binary.tool import Tool + +def test_false(tool:Tool) -> None: + binary = tool("false") + + cmd = (binary, 'hello', '=', 'goodbye') + with pytest.raises(CalledProcessError): + run(cmd, check=True, timeout=30) -- GitLab