From 74504ce30e183bf5100b4fee62cb7963e9eda002 Mon Sep 17 00:00:00 2001
From: Jonathan Watson <jonathan.watson@arm.com>
Date: Tue, 25 Feb 2025 17:03:05 +0000
Subject: [PATCH] test(dirname): add version and dirname test

---
 e2e/binary/dirname/BUILD.bazel | 31 +++++++++++++++++++++++++------
 e2e/binary/dirname/dirname.py  | 13 +++++++++++++
 2 files changed, 38 insertions(+), 6 deletions(-)
 create mode 100644 e2e/binary/dirname/dirname.py

diff --git a/e2e/binary/dirname/BUILD.bazel b/e2e/binary/dirname/BUILD.bazel
index c07709b6..06989f06 100644
--- a/e2e/binary/dirname/BUILD.bazel
+++ b/e2e/binary/dirname/BUILD.bazel
@@ -1,11 +1,30 @@
-load("@bazel_skylib//rules:build_test.bzl", "build_test")
+load("@bazel_skylib//rules:native_binary.bzl", "native_test")
+load("@rules_python_pytest//python_pytest:defs.bzl", "py_pytest_test")
 
-# TODO: write an _actual_ test for `dirname`
+py_pytest_test(
+    name = "pytest",
+    size = "small",
+    srcs = ["dirname.py"],
+    data = [
+        "@ape//ape:dirname",
+    ],
+    deps = [
+        "//binary:pytest",
+    ],
+)
 
-build_test(
-    name = "dirname",
+native_test(
+    name = "version",
     size = "small",
-    tags = ["stub"],
-    targets = ["@ape//ape:dirname"],
+    src = "@ape//ape:dirname",
+    args = ["--version"],
+)
+
+test_suite(
+    name = "dirname",
+    tests = [
+        "pytest",
+        "version",
+    ],
     visibility = ["//:__subpackages__"],
 )
diff --git a/e2e/binary/dirname/dirname.py b/e2e/binary/dirname/dirname.py
new file mode 100644
index 00000000..81f46a7b
--- /dev/null
+++ b/e2e/binary/dirname/dirname.py
@@ -0,0 +1,13 @@
+from __future__ import annotations
+
+from subprocess import run
+
+from binary.tool import Tool
+
+
+def test_dirname(tool: Tool) -> None:
+    binary = tool("dirname")
+
+    cmd = (binary, "/my/great/path/file")
+    result = run(cmd, check=True, timeout=30, capture_output=True, text=True)
+    assert "/my/great/path\n" == result.stdout
-- 
GitLab