From be1b4b3ff1c7863cd99a8feb090e7c3ebfae726f Mon Sep 17 00:00:00 2001 From: Jacob Bohlin Date: Mon, 2 Jun 2025 14:34:04 +0100 Subject: [PATCH] MLBEDSW-10479 Remove incorrect zero point casts for Pad/PadV2 Change-Id: I58a0a8f620c699011d2a115861308413bc0d3f48 Signed-off-by: Jacob Bohlin --- ethosu/regor/compiler/graphir_optimiser.cpp | 2 +- ethosu/regor/compiler/tflite_graph_optimiser.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ethosu/regor/compiler/graphir_optimiser.cpp b/ethosu/regor/compiler/graphir_optimiser.cpp index d0c3b5a5..4732e464 100644 --- a/ethosu/regor/compiler/graphir_optimiser.cpp +++ b/ethosu/regor/compiler/graphir_optimiser.cpp @@ -742,7 +742,7 @@ Operation *GraphIrOptimiser::RewritePad(Graph *const, Operation *const operation const Shape ofmShape = ofmConn->shape; const auto ¶msConn = operation->Input(TensorUsage::Params); const auto &attr = operation->Attribute(); - uint8_t zeroPoint = ofmConn->quantization.IsValid() ? uint8_t(ofmConn->quantization.zeroPoints[0]) : 0; + const int zeroPoint = ofmConn->quantization.IsValid() ? static_cast(ofmConn->quantization.zeroPoints[0]) : 0; const int padConst = int(attr->pad_const) + zeroPoint; // Decode the padding before and after each dimension as two shapes diff --git a/ethosu/regor/compiler/tflite_graph_optimiser.cpp b/ethosu/regor/compiler/tflite_graph_optimiser.cpp index e4a4db81..3aa93dc9 100644 --- a/ethosu/regor/compiler/tflite_graph_optimiser.cpp +++ b/ethosu/regor/compiler/tflite_graph_optimiser.cpp @@ -2527,7 +2527,7 @@ Operation *TFLiteGraphOptimiser::ConvertPadV2(Graph *const graph, Operation *con const auto padConstTens = operation->Input(TensorUsage::Params1)->tensor; // This is undoing the existing zero point adjustment to counteract the zero point adjustment // which is done in GraphIR lowering of Pad. - uint8_t zeroPoint = ofmConn->quantization.IsValid() ? uint8_t(ofmConn->quantization.zeroPoints[0]) : 0; + int zeroPoint = ofmConn->quantization.IsValid() ? static_cast(ofmConn->quantization.zeroPoints[0]) : 0; attr->pad_const = padConstTens->View().Values(padConstTens->Type())[0] - zeroPoint; RecordOptimisation(operation, padOp.get()); -- GitLab